This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: add tenderly urls to sentry metadata #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
agualis
commented
Sep 12, 2024
| @@ -22,6 +22,22 @@ export const queryClient = new QueryClient({ | |||
| captureError(error, { extra: { queryKey: query.queryKey } }) | |||
| }, | |||
| }), | |||
| mutationCache: new MutationCache({ | |||
There was a problem hiding this comment.
Unrelated to tenderly but we were not explicitly capturing mutation errors (they are not frequent as the tx normally fails in the simulation, not in the execution).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tenderly simulation urls to sentry metadata for the main flows: add, remove and swap (for both simulation and execution errors).
How to test? (Swap example)
Comment this line to avoid form input validation:
https://github.com/balancer/frontend-v3/blob/feat/sentryTenderlyUrl/lib/modules/swap/SwapProvider.tsx#L535
Swap with token amount in greater than the wallet balance:
Open the modal and the simulation should fail:
You will see a "
Sentry capturing query error:" in the console:It should contain a valid tenderly url in
meta.context.extra.tenderlyUrl.If sentry capturing was enabled (disabled by default in dev) you would see an issue like this one:
https://balancer-labs.sentry.io/issues/5837469276
Then you can open the tenderly url and simulate from the sentry issue 🎈